Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix hidden column may do not have a virtual expression #52184

Merged
merged 1 commit into from
Mar 28, 2024
Merged

planner: fix hidden column may do not have a virtual expression #52184

merged 1 commit into from
Mar 28, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #52181

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 28, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 07:09:47.292836664 +0000 UTC m=+2138214.315083051: ☑️ agreed by qw4990.
  • 2024-03-28 07:12:54.811723819 +0000 UTC m=+2138401.833970207: ☑️ agreed by hawkingrei.

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Merging #52184 (0dc2524) into master (b942197) will decrease coverage by 17.7147%.
Report is 14 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #52184         +/-   ##
=================================================
- Coverage   72.4092%   54.6946%   -17.7147%     
=================================================
  Files          1487       1601        +114     
  Lines        365652     610510     +244858     
=================================================
+ Hits         264766     333916      +69150     
- Misses        81332     253334     +172002     
- Partials      19554      23260       +3706
Flag Coverage Δ
integration 36.7250% <100.0000%> (?)
unit 70.4606% <100.0000%> (-1.8410%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.5561% <ø> (+5.2267%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990, XuHuaiyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2ae1933 into pingcap:master Mar 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 qw4990 approved these changes

@zimulala zimulala zimulala approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hidden column don't have to own its virtual expression when its a stored type
5 participants
@AilinKid @hawkingrei @zimulala @qw4990 @XuHuaiyu